From 01e3159c01c6e13a9a102bd4c1e09b852c994223 Mon Sep 17 00:00:00 2001
From: Chris Tapp <chris.tapp@keylevel.com>
Date: Sun, 28 Feb 2010 11:54:30 +0100
Subject: [PATCH] Better performance on assigning section IDs FS#1894
---
inc/pageutils.php | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/inc/pageutils.php b/inc/pageutils.php
index b6b1d048b..33b93bd72 100644
--- a/inc/pageutils.php
+++ b/inc/pageutils.php
@@ -198,7 +198,7 @@ function noNSorNS($id) {
* Creates a XHTML valid linkid from a given headline title
*
* @param string $title The headline title
- * @param array $check List of existing IDs
+ * @param array $check Existing IDs (title => number)
* @author Andreas Gohr <andi@splitbrain.org>
*/
function sectionID($title,&$check) {
@@ -212,12 +212,11 @@ function sectionID($title,&$check) {
if(is_array($check)){
// make sure tiles are unique
- $num = '';
- while(in_array($title.$num,$check)){
- ($num) ? $num++ : $num = 1;
+ if (!array_key_exists ($title,$check)) {
+ $check[$title] = 0;
+ } else {
+ $title .= ++ $check[$title];
}
- $title = $title.$num;
- $check[] = $title;
}
return $title;
--
GitLab