diff --git a/_test/tests/inc/form/checkableelement.test.php b/_test/tests/inc/form/checkableelement.test.php index a0e4173e860b470efaae56885875c4fb9003c6a7..e1491f6ece59c30fb2f74ea0ed52ab260d646f8a 100644 --- a/_test/tests/inc/form/checkableelement.test.php +++ b/_test/tests/inc/form/checkableelement.test.php @@ -23,6 +23,7 @@ class form_checkableelement_test extends DokuWikiTest { $this->assertEquals('second', pq($inputs->elements[1])->val()); $this->assertEquals('checked', pq($inputs->elements[0])->attr('checked')); $this->assertEquals('', pq($inputs->elements[1])->attr('checked')); + $this->assertEquals('radio', pq($inputs->elements[0])->attr('type')); } /** @@ -45,5 +46,6 @@ class form_checkableelement_test extends DokuWikiTest { $this->assertEquals('second', pq($inputs->elements[1])->val()); $this->assertEquals('', pq($inputs->elements[0])->attr('checked')); $this->assertEquals('checked', pq($inputs->elements[1])->attr('checked')); + $this->assertEquals('radio', pq($inputs->elements[0])->attr('type')); } } diff --git a/_test/tests/inc/form/inputelement.test.php b/_test/tests/inc/form/inputelement.test.php index 7a5e6d2ea944f349c702bc1907008972c99e0d31..3257d2a892a0ef700e6eec138c15633f12c01aa4 100644 --- a/_test/tests/inc/form/inputelement.test.php +++ b/_test/tests/inc/form/inputelement.test.php @@ -14,6 +14,7 @@ class form_inputelement_test extends DokuWikiTest { $input = $pq->find('input[name=foo]'); $this->assertTrue($input->length == 1); $this->assertEquals('this is text', $input->val()); + $this->assertEquals('text', $input->attr('type')); $label = $pq->find('label'); $this->assertTrue($label->length == 1); @@ -38,4 +39,20 @@ class form_inputelement_test extends DokuWikiTest { $this->assertEquals('a new text', $input->val()); } + function test_password() { + $form = new Form\Form(); + $form->addPasswordInput('foo', 'label text')->val('this is text'); + + $html = $form->toHTML(); + $pq = phpQuery::newDocumentXHTML($html); + + $input = $pq->find('input[name=foo]'); + $this->assertTrue($input->length == 1); + $this->assertEquals('this is text', $input->val()); + $this->assertEquals('password', $input->attr('type')); + + $label = $pq->find('label'); + $this->assertTrue($label->length == 1); + $this->assertEquals('label text', $label->find('span')->text()); + } } diff --git a/inc/Form/InputElement.php b/inc/Form/InputElement.php index 5908f7d11821a586316fe62b09ea94a677fc6926..693eeffc533197a087dc13c2042478fdb0fcb6cb 100644 --- a/inc/Form/InputElement.php +++ b/inc/Form/InputElement.php @@ -29,6 +29,7 @@ class InputElement extends Element { public function __construct($type, $name, $label = '') { parent::__construct($type, array('name' => $name)); $this->attr('name', $name); + $this->attr('type', $type); if($label) $this->label = new Label($label); }