From 1d096a1019c5e9af62c7fd5678fb258a1ea7ed17 Mon Sep 17 00:00:00 2001
From: Andreas Gohr <andi@splitbrain.org>
Date: Fri, 17 Feb 2006 19:07:15 +0100
Subject: [PATCH] fixed password mail
There was an error which caused the mail aent on registration to
contain the crypted password instead of the cleartext one.
darcs-hash:20060217180715-7ad00-88b2e8f74ddbad41300ca53bbf79df3d8d8beebc.gz
---
inc/auth.php | 3 +--
inc/auth/basic.class.php | 3 +--
inc/auth/mysql.class.php | 5 ++---
inc/auth/plain.class.php | 5 ++---
4 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/inc/auth.php b/inc/auth.php
index d8fae97b7..d25003736 100644
--- a/inc/auth.php
+++ b/inc/auth.php
@@ -454,8 +454,7 @@ function register(){
}
//okay try to create the user
- $pass = $auth->createUser($_POST['login'],$pass,$_POST['fullname'],$_POST['email']);
- if(empty($pass)){
+ if(!$auth->createUser($_POST['login'],$pass,$_POST['fullname'],$_POST['email'])){
msg($lang['reguexists'],-1);
return false;
}
diff --git a/inc/auth/basic.class.php b/inc/auth/basic.class.php
index b47a63de9..6046edea1 100644
--- a/inc/auth/basic.class.php
+++ b/inc/auth/basic.class.php
@@ -189,8 +189,7 @@ class auth_basic {
* Create a new User [implement only where required/possible]
*
* Returns false if the user already exists, null when an error
- * occured and the cleartext password of the new user if
- * everything went well.
+ * occured and true if everything went well.
*
* The new user HAS TO be added to the default group by this
* function!
diff --git a/inc/auth/mysql.class.php b/inc/auth/mysql.class.php
index fec617d56..bd8fc42c6 100644
--- a/inc/auth/mysql.class.php
+++ b/inc/auth/mysql.class.php
@@ -165,8 +165,7 @@ class auth_mysql extends auth_basic {
* [public function]
*
* Create a new User. Returns false if the user already exists,
- * null when an error occured and the cleartext password of the
- * new user if everything went well.
+ * null when an error occured and true if everything went well.
*
* The new user will be added to the default group by this
* function if grps are not specified (default behaviour).
@@ -195,7 +194,7 @@ class auth_mysql extends auth_basic {
$rc = $this->_addUser($user,$pwd,$name,$mail,$grps);
$this->_unlockTables();
$this->_closeDB();
- if ($rc) return $pwd;
+ if ($rc) return true;
}
return null; // return error
}
diff --git a/inc/auth/plain.class.php b/inc/auth/plain.class.php
index 2dae8de98..9ab3bc70a 100644
--- a/inc/auth/plain.class.php
+++ b/inc/auth/plain.class.php
@@ -86,8 +86,7 @@ class auth_plain extends auth_basic {
* Create a new User
*
* Returns false if the user already exists, null when an error
- * occured and the cleartext password of the new user if
- * everything went well.
+ * occured and true if everything went well.
*
* The new user will be added to the default group by this
* function if grps are not specified (default behaviour).
@@ -111,7 +110,7 @@ class auth_plain extends auth_basic {
$userline = join(':',array($user,$pass,$name,$mail,$groups))."\n";
if (io_saveFile(AUTH_USERFILE,$userline,true)) {
- $this->users[$user] = compact('pass','name','mail','grps');
+ $this->users[$user] = compact('pass','name','mail','grps');
return $pwd;
}
--
GitLab