From 3d6feb16238ee969cb2ba14a592124052f0c4bc2 Mon Sep 17 00:00:00 2001
From: Michael Hamann <michael@content-space.de>
Date: Sat, 7 Jul 2012 23:06:12 +0200
Subject: [PATCH] Remove useless condition in p_get_metadata and add
 explanation

---
 inc/parserutils.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/inc/parserutils.php b/inc/parserutils.php
index 25d7cf131..55b451c76 100644
--- a/inc/parserutils.php
+++ b/inc/parserutils.php
@@ -318,8 +318,9 @@ function p_get_metadata($id, $key='', $render=METADATA_RENDER_USING_CACHE){
             // only update the file when the metadata has been changed
             if ($meta == $old_meta || p_save_metadata($id, $meta)) {
                 // store a timestamp in order to make sure that the cachefile is touched
+                // this timestamp is also stored when the meta data is still the same
                 $cachefile->storeCache(time());
-            } elseif ($meta != $old_meta) {
+            } else {
                 msg('Unable to save metadata file. Hint: disk full; file permissions; safe_mode setting.',-1);
             }
         }
-- 
GitLab