From 70635395b71e75876aac73b7b10432493ff6c909 Mon Sep 17 00:00:00 2001
From: Andreas Gohr <andi@splitbrain.org>
Date: Fri, 3 Feb 2017 11:23:32 +0100
Subject: [PATCH] fix pass by reference bug identified by scrutinizer
$pagelog->getRevisions(-1, 1) cannot be passed to array_pop() as the
parameter $array expects a reference.
---
inc/html.php | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/inc/html.php b/inc/html.php
index d3bf6a6f8..70ba4dcfe 100644
--- a/inc/html.php
+++ b/inc/html.php
@@ -551,7 +551,8 @@ function html_revisions($first=0, $media_id = false){
}
}
$pagelog = new PageChangeLog($ID);
- $latestrev = array_pop($pagelog->getRevisions(-1, 1));
+ $latestrev = $pagelog->getRevisions(-1, 1);
+ $latestrev = array_pop($latestrev);
$href = wl($id,"rev=$latestrev",false,'&');
$summary = $INFO['sum'];
$editor = $INFO['editor'];
--
GitLab