From a86cc527f2653a972a7416116630b5be5c3e380c Mon Sep 17 00:00:00 2001
From: Andreas Gohr <andi@splitbrain.org>
Date: Sat, 15 Oct 2011 11:24:19 +0200
Subject: [PATCH] Fix performance issue in close_paragraph
Looks like a for loop is faster than array_splice
---
inc/parser/handler.php | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/inc/parser/handler.php b/inc/parser/handler.php
index 0e54425f7..24d880e2d 100644
--- a/inc/parser/handler.php
+++ b/inc/parser/handler.php
@@ -1520,7 +1520,8 @@ class Doku_Handler_Block {
if(trim($content)==''){
//remove the whole paragraph
- array_splice($this->calls,$i);
+ //array_splice($this->calls,$i); // <- this is much slower than the loop below
+ for($x=$ccount-1; $x>=$i; $x--) unset($this->calls[$x]);
}else{
// remove ending linebreaks in the paragraph
$i=count($this->calls)-1;
--
GitLab