diff --git a/inc/Action/AbstractAliasAction.php b/inc/Action/AbstractAliasAction.php index f61f39a88948235e1ae81a438bd24ded0f73b885..7240f5edf0f11ba6d89d48db162dde9bf54f1506 100644 --- a/inc/Action/AbstractAliasAction.php +++ b/inc/Action/AbstractAliasAction.php @@ -17,7 +17,7 @@ use dokuwiki\Action\Exception\FatalException; abstract class AbstractAliasAction extends AbstractAction { /** @inheritdoc */ - function minimumPermission() { + public function minimumPermission() { return AUTH_NONE; } diff --git a/inc/Action/Resendpwd.php b/inc/Action/Resendpwd.php index 466e078a41fa54fa3e7d440165fd9b4f5a9f38a7..80f05e05625ed1eb0df841c51a5e7f3b7266b22b 100644 --- a/inc/Action/Resendpwd.php +++ b/inc/Action/Resendpwd.php @@ -51,7 +51,7 @@ class Resendpwd extends AbstractAclAction { * @fixme this should be split up into multiple methods * @return bool true on success, false on any error */ - function resendpwd() { + protected function resendpwd() { global $lang; global $conf; /* @var \DokuWiki_Auth_Plugin $auth */ diff --git a/inc/ActionRouter.php b/inc/ActionRouter.php index cb2df70adc3a7b30231362855bed0e763a838895..22ff94c4ec9c29a1f44fe0e58af0f8f5840ebc3e 100644 --- a/inc/ActionRouter.php +++ b/inc/ActionRouter.php @@ -177,7 +177,7 @@ class ActionRouter { public function loadAction($actionname) { $actionname = strtolower($actionname); // FIXME is this needed here? should we run a cleanup somewhere else? $parts = explode('_', $actionname); - while($parts) { + while(!empty($parts)) { $load = join('_', $parts); $class = 'dokuwiki\\Action\\' . str_replace('_', '', ucwords($load, '_')); if(class_exists($class)) {