From d5d08c05f8ec61723fc75d1e8fa22f24c664fdbb Mon Sep 17 00:00:00 2001
From: Andreas Gohr <andi@splitbrain.org>
Date: Sun, 27 Aug 2017 09:40:53 +0200
Subject: [PATCH] fixed some style errors found by scrutinizer
---
inc/Action/AbstractAliasAction.php | 2 +-
inc/Action/Resendpwd.php | 2 +-
inc/ActionRouter.php | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/inc/Action/AbstractAliasAction.php b/inc/Action/AbstractAliasAction.php
index f61f39a88..7240f5edf 100644
--- a/inc/Action/AbstractAliasAction.php
+++ b/inc/Action/AbstractAliasAction.php
@@ -17,7 +17,7 @@ use dokuwiki\Action\Exception\FatalException;
abstract class AbstractAliasAction extends AbstractAction {
/** @inheritdoc */
- function minimumPermission() {
+ public function minimumPermission() {
return AUTH_NONE;
}
diff --git a/inc/Action/Resendpwd.php b/inc/Action/Resendpwd.php
index 466e078a4..80f05e056 100644
--- a/inc/Action/Resendpwd.php
+++ b/inc/Action/Resendpwd.php
@@ -51,7 +51,7 @@ class Resendpwd extends AbstractAclAction {
* @fixme this should be split up into multiple methods
* @return bool true on success, false on any error
*/
- function resendpwd() {
+ protected function resendpwd() {
global $lang;
global $conf;
/* @var \DokuWiki_Auth_Plugin $auth */
diff --git a/inc/ActionRouter.php b/inc/ActionRouter.php
index cb2df70ad..22ff94c4e 100644
--- a/inc/ActionRouter.php
+++ b/inc/ActionRouter.php
@@ -177,7 +177,7 @@ class ActionRouter {
public function loadAction($actionname) {
$actionname = strtolower($actionname); // FIXME is this needed here? should we run a cleanup somewhere else?
$parts = explode('_', $actionname);
- while($parts) {
+ while(!empty($parts)) {
$load = join('_', $parts);
$class = 'dokuwiki\\Action\\' . str_replace('_', '', ucwords($load, '_'));
if(class_exists($class)) {
--
GitLab