Skip to content
Snippets Groups Projects
  • Angus Gratton's avatar
    86c04d87
    Fix for update messages never completely going away · 86c04d87
    Angus Gratton authored
    The existing logic for messages.txt requires some valid update
    response (ending in %) to the messages update check before it clears
    the current messages.
    
    However update.dokuwiki.org appears to return an empty string response
    if everything is up to date. (ie http://update.dokuwiki.org/check/46.1 )
    
    As a result if there are update messages in messages.txt they don't
    automatically go away after updating to the current version. The only
    time they change is when a newer release comes out. The upgrade plugin
    has logic in it to force a re-download of messages.txt, but currently
    this just re-downloads the old update messages.
    
    This change explicitly allows for "" as a valid "no messages"
    indicator (distinct from false, which is the HTTP error indicator.)
    86c04d87
    History
    Fix for update messages never completely going away
    Angus Gratton authored
    The existing logic for messages.txt requires some valid update
    response (ending in %) to the messages update check before it clears
    the current messages.
    
    However update.dokuwiki.org appears to return an empty string response
    if everything is up to date. (ie http://update.dokuwiki.org/check/46.1 )
    
    As a result if there are update messages in messages.txt they don't
    automatically go away after updating to the current version. The only
    time they change is when a newer release comes out. The upgrade plugin
    has logic in it to force a re-download of messages.txt, but currently
    this just re-downloads the old update messages.
    
    This change explicitly allows for "" as a valid "no messages"
    indicator (distinct from false, which is the HTTP error indicator.)
Code owners
Assign users and groups as approvers for specific file changes. Learn more.