overwrite item properties in constructor only

Othewise weird side effects may happen when a parent constructor
overwrites them again.

inc/Menu/Item/Admin.php

@@ -9,13 +9,13 @@ namespace dokuwiki\Menu\Item;
  */
 class Admin extends AbstractItem {
 
-    protected $svg = DOKU_INC . 'lib/images/menu/settings.svg';
-
     /** @inheritdoc */
     public function __construct() {
         global $INFO;
         parent::__construct();
 
+        $this->svg = DOKU_INC . 'lib/images/menu/settings.svg';
+
         if(!$INFO['ismanager']) {
             throw new \RuntimeException("admin is for managers only");
         }

inc/Menu/Item/Backlink.php

@@ -9,6 +9,10 @@ namespace dokuwiki\Menu\Item;
  */
 class Backlink extends AbstractItem {
 
-    protected $svg = DOKU_INC . 'lib/images/menu/08-backlink_link-variant.svg';
+    /** @inheritdoc */
+    public function __construct() {
+        parent::__construct();
+        $this->svg = DOKU_INC . 'lib/images/menu/08-backlink_link-variant.svg';
+    }
 
 }

inc/Menu/Item/Index.php

@@ -9,8 +9,6 @@ namespace dokuwiki\Menu\Item;
  */
 class Index extends AbstractItem {
 
-    protected $svg = DOKU_INC . 'lib/images/menu/file-tree.svg';
-
     /** @inheritdoc */
     public function __construct() {
         global $conf;
@@ -18,6 +16,7 @@ class Index extends AbstractItem {
         parent::__construct();
 
         $this->accesskey = 'x';
+        $this->svg = DOKU_INC . 'lib/images/menu/file-tree.svg';
 
         // allow searchbots to get to the sitemap from the homepage (when dokuwiki isn't providing a sitemap.xml)
         if($conf['start'] == $ID && !$conf['sitemap']) {

inc/Menu/Item/Login.php

@@ -9,13 +9,12 @@ namespace dokuwiki\Menu\Item;
  */
 class Login extends AbstractItem {
 
-    protected $svg = DOKU_INC . 'lib/images/menu/login.svg';
-
     /** @inheritdoc */
     public function __construct() {
         global $INPUT;
         parent::__construct();
 
+        $this->svg = DOKU_INC . 'lib/images/menu/login.svg';
         $this->params['sectok'] = getSecurityToken();
         if($INPUT->server->has('REMOTE_USER')) {
             if(!actionOK('logout')) {

inc/Menu/Item/Media.php

@@ -9,14 +9,13 @@ namespace dokuwiki\Menu\Item;
  */
 class Media extends AbstractItem {
 
-    protected $svg = DOKU_INC . 'lib/images/menu/folder-multiple-image.svg';
-
     /** @inheritdoc */
     public function __construct() {
         global $ID;
         parent::__construct();
 
-        $params['ns'] = getNS($ID);
+        $this->svg = DOKU_INC . 'lib/images/menu/folder-multiple-image.svg';
+        $this->params['ns'] = getNS($ID);
     }
 
 }

inc/Menu/Item/MediaManager.php

@@ -9,8 +9,6 @@ namespace dokuwiki\Menu\Item;
  */
 class MediaManager extends AbstractItem {
 
-    protected $svg = DOKU_INC . 'lib/images/menu/11-mediamanager_folder-image.svg';
-
     /** @inheritdoc */
     public function __construct() {
         global $IMG;
@@ -21,6 +19,8 @@ class MediaManager extends AbstractItem {
         if($authNS < AUTH_UPLOAD) {
             throw new \RuntimeException("media manager link only with upload permissions");
         }
+
+        $this->svg = DOKU_INC . 'lib/images/menu/11-mediamanager_folder-image.svg';
         $this->params = array(
             'ns' => $imgNS,
             'image' => $IMG,

inc/Menu/Item/Profile.php

@@ -9,8 +9,6 @@ namespace dokuwiki\Menu\Item;
  */
 class Profile extends AbstractItem {
 
-    protected $svg = DOKU_INC . 'lib/images/menu/account-card-details.svg';
-
     /** @inheritdoc */
     public function __construct() {
         global $INPUT;
@@ -19,6 +17,8 @@ class Profile extends AbstractItem {
         if(!$INPUT->server->str('REMOTE_USER')) {
             throw new \RuntimeException("profile is only for logged in users");
         }
+
+        $this->svg = DOKU_INC . 'lib/images/menu/account-card-details.svg';
     }
 
 }

inc/Menu/Item/Revisions.php

@@ -13,6 +13,7 @@ class Revisions extends AbstractItem {
     public function __construct() {
         parent::__construct();
 
+        $this->accesskey = 'o';
         $this->type = 'revs';
         $this->svg = DOKU_INC . 'lib/images/menu/07-revisions_history.svg';
     }

inc/Menu/Item/Subscribe.php

@@ -9,8 +9,6 @@ namespace dokuwiki\Menu\Item;
  */
 class Subscribe extends AbstractItem {
 
-    protected $svg = DOKU_INC . 'lib/images/menu/09-subscribe_email-outline.svg';
-
     /** @inheritdoc */
     public function __construct() {
         global $INPUT;
@@ -19,6 +17,8 @@ class Subscribe extends AbstractItem {
         if(!$INPUT->server->str('REMOTE_USER')) {
             throw new \RuntimeException("subscribe is only for logged in users");
         }
+
+        $this->svg = DOKU_INC . 'lib/images/menu/09-subscribe_email-outline.svg';
     }
 
 }

inc/Menu/Item/Top.php

@@ -10,10 +10,15 @@ namespace dokuwiki\Menu\Item;
  */
 class Top extends AbstractItem {
 
-    protected $svg       = DOKU_INC . 'lib/images/menu/10-top_arrow-up.svg';
-    protected $accesskey = 't';
-    protected $params    = array('do' => '');
-    protected $id        = '#dokuwiki__top';
-    protected $context   = self::CTX_DESKTOP;
+    /** @inheritdoc */
+    public function __construct() {
+        parent::__construct();
+
+        $this->svg = DOKU_INC . 'lib/images/menu/10-top_arrow-up.svg';
+        $this->accesskey = 't';
+        $this->params = array('do' => '');
+        $this->id = '#dokuwiki__top';
+        $this->context = self::CTX_DESKTOP;
+    }
 
 }