Skip to content
Snippets Groups Projects
Commit 9e8bcd5f authored by Andreas Gohr's avatar Andreas Gohr
Browse files

fix possible XSS vulnerability in Plugin Manager

The plugin manager echos raw URLs in error messages, this could allow to
construct an XSS attack. However the affected form is CSRF protected,
so an attacker would require another XSS vulnerability to get the needed token,
rendering this attack unneeded. So this should not be exploitable.
parent 8c4759c9
No related branches found
No related tags found
No related merge requests found
......@@ -24,7 +24,7 @@ class ap_download extends ap_manage {
ptln('<h2>'.$this->lang['downloading'].'</h2>');
if ($this->manager->error) {
ptln('<div class="error">'.str_replace("\n","<br />",$this->manager->error).'</div>');
ptln('<div class="error">'.str_replace("\n","<br />",hsc($this->manager->error)).'</div>');
} else if (count($this->downloaded) == 1) {
ptln('<p>'.sprintf($this->lang['downloaded'],$this->downloaded[0]).'</p>');
} else if (count($this->downloaded)) { // more than one plugin in the download
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment