Skip to content
Snippets Groups Projects
  • Michael Hamann's avatar
    77244e70
    Security: Fix ACL check in search_allpages · 77244e70
    Michael Hamann authored
    Due to the changes in 8f34cf3d, the ACL
    check in search_allpages was only executed when 'skipacl' has been
    explicitly set to false. Otherwise, only ACLs for namespaces were
    checked (unless the sneakyacl option was passed). The documentation
    states that the default for 'skipacl' is false, so setting it to false
    shouldn't be necessary.
    
    From all I can see, this does not concern DokuWiki itself as
    search_allpages is never used without the 'skipacl' option explicitly
    set to true or false. However, this causes serious security issues in
    plugins that rely on this ACL check in search_allpages like the include
    plugin.
    77244e70
    History
    Security: Fix ACL check in search_allpages
    Michael Hamann authored
    Due to the changes in 8f34cf3d, the ACL
    check in search_allpages was only executed when 'skipacl' has been
    explicitly set to false. Otherwise, only ACLs for namespaces were
    checked (unless the sneakyacl option was passed). The documentation
    states that the default for 'skipacl' is false, so setting it to false
    shouldn't be necessary.
    
    From all I can see, this does not concern DokuWiki itself as
    search_allpages is never used without the 'skipacl' option explicitly
    set to true or false. However, this causes serious security issues in
    plugins that rely on this ACL check in search_allpages like the include
    plugin.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.