Skip to content
Snippets Groups Projects
  1. Jan 02, 2019
  2. Dec 26, 2018
  3. Dec 22, 2018
  4. Dec 15, 2018
  5. Dec 12, 2018
  6. Dec 10, 2018
  7. Dec 08, 2018
  8. Nov 29, 2018
    • Michael Hamann's avatar
      Security: Fix ACL check in search_allpages · 77244e70
      Michael Hamann authored
      Due to the changes in 8f34cf3d, the ACL
      check in search_allpages was only executed when 'skipacl' has been
      explicitly set to false. Otherwise, only ACLs for namespaces were
      checked (unless the sneakyacl option was passed). The documentation
      states that the default for 'skipacl' is false, so setting it to false
      shouldn't be necessary.
      
      From all I can see, this does not concern DokuWiki itself as
      search_allpages is never used without the 'skipacl' option explicitly
      set to true or false. However, this causes serious security issues in
      plugins that rely on this ACL check in search_allpages like the include
      plugin.
      77244e70
  9. Nov 28, 2018
  10. Nov 27, 2018
  11. Nov 24, 2018
  12. Nov 23, 2018
  13. Nov 20, 2018
  14. Nov 19, 2018
  15. Nov 14, 2018
  16. Nov 11, 2018
  17. Nov 10, 2018
  18. Nov 06, 2018
  19. Nov 05, 2018
  20. Nov 03, 2018
  21. Oct 30, 2018
    • Andreas Gohr's avatar
      Admin Menu Item should not throw an exception · 3d90b12c
      Andreas Gohr authored
      instead the visibility is properly checked in the visibleInContext()
      method.
      3d90b12c
    • Andreas Gohr's avatar
      relax access to admin action · 4f32ee18
      Andreas Gohr authored
      Since we want to check the access to the Admin plugins on an individual
      basis, we need to grant access to all logged in users at first. This
      means a user could access the admin page, but would not see any plugins
      available.
      4f32ee18
    • Andreas Gohr's avatar
      add event to check access to admin plugins · 64cdf779
      Andreas Gohr authored
      This adds a new method that capsulates the access check that has to be
      done to decide if an admin plugin's page should be shown to the user.
      The default implementation is the same as before, relying only on the
      forAdminOnly() method and the users' isadmin or ismanager status.
      
      Admin plugins themselves can override the method to do additional
      checks. In this patch, I added that to the usermanager plugin which will
      only return true if the current auth backend can list users.
      
      However the real idea behind this change is that the new method emits a
      new event called ADMINPLUGIN_ACCESS_CHECK which would allow plugins to
      overwrite it. This way it could be possible to give certain user groups
      access to certain admin plugins without giving them admin or manager
      permissions.
      
      Note: this does not change how the "Admin" link is shown, it still
      depends on ismanager or isadmin. A plugin as mentioned above would need
      to influence the display via the MENU_ITEMS_ASSEMBLY event.
      
      Note: this only covers the basic access check. Admin plugins may need
      further adjustments for access to other parts of the plugin (like AJAX
      components). An additional commit will update this for the bundled
      plugins.
      64cdf779
  22. Oct 26, 2018
  23. Oct 17, 2018
Loading