Skip to content
Snippets Groups Projects
  1. May 19, 2017
    • Andreas Gohr's avatar
      menu SVGs now become proper part of core · 3e2fa388
      Andreas Gohr authored
      all menu items should have a default SVG. Template authors then can
      decide if they want to use them or not.
      
      These are only the page tool SVGs. More need to be added.
      3e2fa388
    • Andreas Gohr's avatar
      beginning of a complete refactoring of the menues · 93b8c351
      Andreas Gohr authored
      This is an attempt to:
      
      * get rid of the super long, complex functions in in/template.php
      * make it easy for plugin authors to add their own items to any
        of our menus, regardless of the used template
      * continue the progress to make use of SVG in the menues
      
      This takes a similar approach as my actionrefactor branch. Originially
      I thought both refactorings could be done in one, merging the
      functionality of DokuWiki actions and the menu items. However I couldn't
      make it work. So instead we have two separate but similar things.
      Maybe they can converge later on.
      93b8c351
  2. Feb 06, 2017
    • Andreas Gohr's avatar
      added RTL styles · 08ee0671
      Andreas Gohr authored
      08ee0671
    • Andreas Gohr's avatar
      smaller icons, less vertical space · a6fbb60b
      Andreas Gohr authored
      a6fbb60b
    • Andreas Gohr's avatar
      created distinct create image, optimized images · 40272563
      Andreas Gohr authored
      I used svgo to strip all unneeded cruft from the svgs
      40272563
    • Andreas Gohr's avatar
      made pageToolItem() more flexible · fb03ffd3
      Andreas Gohr authored
      Now any arbitrary attributes can be passed as 4th argument. This way
      classes etc could be added by plugins.
      fb03ffd3
    • Andreas Gohr's avatar
      adjust the event · db433680
      Andreas Gohr authored
      This will open up the discussion from #236 again and I'm not sure how to
      solve this best.
      
      The TEMPLATE_PAGETOOLS_DISPLAY event is very specific to the dokuwiki
      template in theory. In practice many other templates implemented not
      only the same event but also use the same HTML (and often even the same
      CSS). Which makes the event more like a core event.
      
      This branch now changes the HTML the event expects back from handlers.
      When merged it would immeadiately break all plugins implementing this
      event (and by broken I mean the layout/design of the template breaks).
      
      Since the expected data changes, I would argue this should be a new
      event or at least be implemented in a way to not break the design by
      installing an old plugin and by giving the plugin a chance to know if
      it's running on the old or the new code.
      
      This is what this commit does. By changing the view names, old plugins
      should not display (because they hopefull do not handle those views) but
      gives them an easy way to handle the old and new views in one plugin.
      
      However, I'm not perfectly happy with it, yet.
      
      The way I implemented the new SVG handling is by means of a new class
      dokuwiki\template\dokuwiki\tpl which provides a pageToolAction() method.
      Plugins could use this method to easily return the proper HTML for the
      pagetool items and we could adjust this method later on to make
      adjustments to the pagetools without breaking anything again.
      
      However this method is template specific again. While it would possible
      for plugins to use this method even when the wiki runs another plugin
      emitting the event, it would be a bit weird.
      
      A better way would be for the event to not expect HTML at all, but
      instead a data structure of the data currently passed to
      pageToolAction(). Templates could then decide to implement the event,
      but still render the data in a completely different way...
      
      OTOH this means plugins are no longer free to add whatever they want
      into the pagetools. We once argued plugins might want to add submenus or
      other fancy stuff there. But in fact no plugin ever did.
      
      If we decide to go this new way of making the event more of a first
      class citizen of template development, then we would probably have to
      move parts or all of the tpl class back to the core.
      db433680
    • Andreas Gohr's avatar
      adjusted function name · 07932c8c
      Andreas Gohr authored
      07932c8c
    • Andreas Gohr's avatar
      Merge branch 'master' into svgpagetools · a54c8d9e
      Andreas Gohr authored
      * master:
        translation update
        fixed typo in function name
        translation update
      a54c8d9e
    • Andreas Gohr's avatar
      Merge pull request #1820 from dokuwiki-translate/lang_update_256 · d70f846e
      Andreas Gohr authored
      Translation update (ja)
      d70f846e
    • Satoshi Sahara's avatar
      translation update · fafff83c
      Satoshi Sahara authored
      fafff83c
  3. Feb 05, 2017
  4. Feb 04, 2017
  5. Feb 03, 2017
  6. Jan 31, 2017
  7. Jan 30, 2017
  8. Jan 29, 2017
  9. Jan 24, 2017
Loading