Skip to content
Snippets Groups Projects
  1. Oct 30, 2018
    • Andreas Gohr's avatar
      relax access to admin action · 4f32ee18
      Andreas Gohr authored
      Since we want to check the access to the Admin plugins on an individual
      basis, we need to grant access to all logged in users at first. This
      means a user could access the admin page, but would not see any plugins
      available.
      4f32ee18
    • Andreas Gohr's avatar
      add event to check access to admin plugins · 64cdf779
      Andreas Gohr authored
      This adds a new method that capsulates the access check that has to be
      done to decide if an admin plugin's page should be shown to the user.
      The default implementation is the same as before, relying only on the
      forAdminOnly() method and the users' isadmin or ismanager status.
      
      Admin plugins themselves can override the method to do additional
      checks. In this patch, I added that to the usermanager plugin which will
      only return true if the current auth backend can list users.
      
      However the real idea behind this change is that the new method emits a
      new event called ADMINPLUGIN_ACCESS_CHECK which would allow plugins to
      overwrite it. This way it could be possible to give certain user groups
      access to certain admin plugins without giving them admin or manager
      permissions.
      
      Note: this does not change how the "Admin" link is shown, it still
      depends on ismanager or isadmin. A plugin as mentioned above would need
      to influence the display via the MENU_ITEMS_ASSEMBLY event.
      
      Note: this only covers the basic access check. Admin plugins may need
      further adjustments for access to other parts of the plugin (like AJAX
      components). An additional commit will update this for the bundled
      plugins.
      64cdf779
  2. Oct 26, 2018
  3. Oct 17, 2018
  4. Oct 16, 2018
  5. Oct 14, 2018
  6. Oct 12, 2018
  7. Oct 11, 2018
  8. Oct 08, 2018
  9. Sep 27, 2018
  10. Sep 20, 2018
  11. Sep 19, 2018
  12. Sep 15, 2018
  13. Sep 12, 2018
  14. Sep 11, 2018
  15. Sep 10, 2018
  16. Sep 08, 2018
  17. Sep 07, 2018
  18. Aug 28, 2018
  19. Aug 25, 2018
  20. Aug 24, 2018
  21. Aug 20, 2018
  22. Aug 17, 2018
    • Andreas Gohr's avatar
      fix #2466. Avoid caching half fetched files · 9ae1a5d1
      Andreas Gohr authored
      When a remote resource exceeds the fetchsize but the remote server does
      not return a Content-Length, we read only the fetchsize amount of bytes
      but failed to detect that this was a partial read, thus a partial
      resource got cached.
      
      This fix will read fetchsize+1, which will then be correctly determined
      as too big and thrown away.
      9ae1a5d1
    • Michael Braun's avatar
      Fix Locked-Page not showing page content · 1b0e85da
      Michael Braun authored
      
      While refactoring into inc/Action/Locked, the fall-through call
      to html_edit was missed.
      See 952acff9
      
      This removed the edit box from the locked page, which is needed
      for users to get the page source or by etherpad lite plugin.
      
      This change re-adds the call to html_edit for the locked action.
      
      Signed-off-by: default avatarMichael Braun <michael-dev@fami-braun.de>
      1b0e85da
  23. Aug 16, 2018
  24. Aug 10, 2018
  25. Aug 04, 2018
  26. Aug 01, 2018
  27. Jul 27, 2018
Loading