Skip to content
Snippets Groups Projects
  1. Jan 10, 2011
    • Michael Hamann's avatar
      Fix msg() calls when messages have already been printed · cc58224c
      Michael Hamann authored
      This commit fixes two bugs that occurred when msg() was called after
      html_msgarea() had already been called.
      - the $MSG array is now cleared when it has been printed (otherwise $MSG
        has been printed again when another msg() call was done)
      - headers_sent() didn't work for me, it always reported false although
        html_msgarea() had already been called which might be explainable with
        output buffering. This makes msg() now depend on the first call of
        html_msgarea() or headers_sent() in order to not to break msg() in
        ajax requests etc.
      cc58224c
    • Michael Hamann's avatar
      Use title index for more than 11 p_first_heading calls · bf0c93c2
      Michael Hamann authored
      This change makes p_get_first_heading load the title index when more
      than 11 requests that caused a call to p_get_metadata have already been
      done. This means that small pages and the breadcrums won't trigger the
      loading of the title index but for larger pages or the sitemap the title
      index will be used. This is necessary because every call to
      p_get_metadata can trigger the parsing and rendering of a whole page and
      there can be many calls when useheading is activated and e.g. the
      index/sitemap page is displayed.
      
      Additionally this adds a small title cache that caches titles requested
      from p_get_metadata.
      
      Further tests should be done how this affects memory usage and how often
      the index loading is triggered in order to see if that parameter should
      be adjusted.
      bf0c93c2
    • Michael Hamann's avatar
      Activate the render parameter of p_get_metadata · 4a819402
      Michael Hamann authored
      p_get_metadata has a $render parameter that has been disabled by the
      restructuring of metadata rendering. This change reactivates it so
      rendering metadata can be prevented. This is e.g. used in the search and
      in some plugins like indexmenu that use p_get_first_heading. The default
      of the parameter has been changed to true as otherwise the new caching
      structure won't work as almost all calls to p_get_metadata don't set the
      $render parameter.
      The indexer call to p_get_first_heading has been changed to set $render
      to true as in the indexer only one page will be rendered and the title
      in the index should really be the current one.
      This does not fix the problem that rendering pages with lots of links or
      displaying the index can cause the parsing/rendering of a lot of pages.
      4a819402
    • Michael Hamann's avatar
      Use md5 of the id in the subscription lockdir. FS#2112 · d6a4a040
      Michael Hamann authored
      Filenames can't contain ":" on windows and the lock directory contained
      the unescaped page id. The lock function tries in an endless loop to
      create the lock directory when it fails and the directory doesn't exist.
      Just escaping the directory name won't work as then the filename length
      limit will be quickly hit when using deep namespace structures with utf8
      names. Thus using the md5sum seems to be the best solution. Perhaps the
      lock function could also be changed to create a file with that name that
      contains the id so the id can be retrieved for debugging purposes.
      d6a4a040
  2. Jan 09, 2011
  3. Jan 06, 2011
  4. Jan 04, 2011
  5. Jan 03, 2011
  6. Jan 02, 2011
  7. Dec 31, 2010
  8. Dec 29, 2010
  9. Dec 28, 2010
  10. Dec 27, 2010
    • Michael Hamann's avatar
      Save metadata only when really changed · 69ba640b
      Michael Hamann authored
      This avoids disk writes when not needed and possibly also xhtml
      rendering when the metadata needs to be rendered but xhtml doesn't
      (unless the metadata file is changed).
      69ba640b
  11. Dec 26, 2010
  12. Dec 23, 2010
  13. Dec 22, 2010
  14. Dec 21, 2010
  15. Dec 18, 2010
  16. Dec 13, 2010
  17. Dec 12, 2010
  18. Dec 10, 2010
    • Michael Hamann's avatar
      preg_quote namespaces in auth_aclcheck · 3e304b55
      Michael Hamann authored
      Like ids namespaces are now preg_quoted in the acl check (and therefore
      the escaping of "*" has been removed). When plugins call the ACL check
      function with strange ids the regex fails otherwise (in the case of the
      include plugin errors like "Warning: preg_grep() [function.preg-grep]:
      Compilation failed: missing terminating ] for character class at offset
      47" have been reported by two users).
      
      I've run the acl tests after this change and everything passes so this
      shouldn't break anything but please test this especially with protected
      wikis as this change modifies the code that handles namespace
      permissions. Furthermore permissions for a namespace foobar are no
      longer applied to namespaces with names like foo.ar, I hope nobody has
      used that "feature".
      
      When you are using per-user namespaces, user registration is open and
      either write or read protection for these namespaces is important to
      you this is a security fix for you: When someone wants to get access to
      the namespace of a user "foo.bar" he can register as "fooxbar" (where
      "x" is an arbitrary character) and will have access to the user
      namespace of the user "foo.bar" as when a page in "foo.bar" is checked
      it will match the rule for "fooxbar".
      3e304b55
    • Andreas Gohr's avatar
      added missing files for popularity plugin · 8596046d
      Andreas Gohr authored
      8596046d
  19. Dec 09, 2010
Loading