Not sure why this didn't show up sooner 

This change is useful for plugins that may want to implement their own toolbar (and thus hide the
default toolbar), but still would like to let the locktimer set the draft status.

The actual draft text got lost when we changed to showing the diff
instead of the full draft.

and actually use it in the edit form.

Before this change, HTML and some JS code (as far as it was not escaped
by json_encode) could be injected into the output as the closing pattern
that is checked by the regex is not escaped in JSON (see test case).

This fixes broken nested section edit buttons which were causing
invalid HTML code. The pattern has to be 'not greedy'. Fixes #2304.

This commit should be without functional changes.

The data for the section edit button is now passed as an assoziative array which is
encoded in the '#<!-- EDIT(.*) -->#' placeholder as an JSON array.

To prevent abusing this functionality for inserting arbitrary html,
inlineSVG is now called inside the html_btn function.

Per request of @splitbrain

Added to #scroll__here, #index__tree, #draft__status, #tool__bar, #dw__toc. This in in re: #2172

Show the diff between the local draft and the remote head version, instead of the fulltext of the local draft.

Since the hid is optional, it must also be optional in the regex. Also
this commit introduced named capture groups to make it more obvious
which part of the regex captures what.

Also there is now an explicit hid generated for tables, to enable
jumping to the correct section after finishing editing.

This was broken in 2571786c or #1966
respectively.

Known Issues:
* since both title and hid are optional, a hid may be misinterpreted as
a title if the title is not generated.

This function might be called by an plugin with an array that has only
string keys and hence no key 0. This would trigger an PHP Notice when
trying to get the first key's level.

$regex initialization added to clearify that it is passed by reference and filled from subroutines

Across workflow 'show - sectionedit - save/cancel' explicitly
transmit header id to the server. So the server can always redirect to
the correct section even if headings have the same name. Fixes #1364.

There are still some left in the DifferenceEngine code

I supplemented the existing comments on the methods in which there was not enough information to the standard phpDoc.

I supplemented the existing comments on the methods in which there was not enough information to the standard phpDoc.

I supplemented the existing comments on the methods in which there was not enough information to the standard phpDoc.

$pagelog->getRevisions(-1, 1) cannot be passed to array_pop() as the
parameter $array expects a reference.

This introduces a new dokuwiki\Ui namespace and refactors the Admin
screen into a Ui class. The ultimate goal is to split up the big,
complex functions in inc\html.php in better maintainable classes in the
Ui namespace. This is the first go at it. Others function->class
conversions should follow.

This also switches the icons for our base admin plugins to inline SVG.
(files and styling not included, yet).

This introduces an embedSVG() function that can be used at other places.

Squashed commit of the following:

commit 86183b66c5b53b47e5ddb1e0d1c155c06c331d35
Merge: ebfb1ab1 4a8f4288e
Author: Andreas Gohr <andi@splitbrain.org>
Date:   Sat Jan 21 11:20:32 2017 +0100

    Merge branch 'master' of git://github.com/ThisNameIsNotAllowed/dokuwiki into pull-request-1767

    * 'master' of git://github.com/ThisNameIsNotAllowed/dokuwiki:
      Update admin.php
      Update admin.php
      Update _admin.css
      Update admin.php
      Update html.php
      Update _admin.css
      Update html.php
      Update html.php
      Update html.php
      Update.html
      Update html.php
      Update admin.php

commit 4a8f4288e61d48156bf9c4a7c49756912e4dac25
Author: ThisNameIsNotAllowed <ThisNameIsNotAllowed@users.noreply.github.com>
Date:   Fri Jan 20 09:25:52 2017 +0100

    Update admin.php

    Changed the code to check for icons being SVG files.
    This should fix php5.3 errors for using method returns straight on.

commit e43b6cae1e12c1d24efae301e6b25f79a660f353
Author: ThisNameIsNotAllowed <ThisNameIsNotAllowed@users.noreply.github.com>
Date:   Fri Jan 20 08:22:41 2017 +0100

    Update admin.php

    Removed elements that could lead to behaviors that shouldn't occure.

commit 9af82fb6f43a5ce10ba9b54f1d5f5cac644c7611
Merge: b99c67797 0b8d1871c
Author: ThisNameIsNotAllowed <ThisNameIsNotAllowed@users.noreply.github.com>
Date:   Thu Jan 19 16:22:02 2017 +0100

    Merge pull request #1 from ThisNameIsNotAllowed/add-c

    Added css, forced the author to use ".svg"-files for plugin icons.

commit 0b8d1871c8bd0a02aca3ff56128465e8739c96ea
Author: ThisNameIsNotAllowed <ThisNameIsNotAllowed@users.noreply.github.com>
Date:   Thu Jan 19 16:17:34 2017 +0100

    Update _admin.css

    fixed some aligning for plugin names.

commit 9158649de99867574471a2b894f8611bb99b9a7f
Author: ThisNameIsNotAllowed <ThisNameIsNotAllowed@users.noreply.github.com>
Date:   Thu Jan 19 15:49:20 2017 +0100

    Update admin.php

    Added method to return menu icons only in case their mime type matches svg files.

    Added warning to getMenuIcon comments telling the user to provide svg only.

commit 6df4e0f41880d40f0e7b1882d26fc647d6d2188e
Author: ThisNameIsNotAllowed <ThisNameIsNotAllowed@users.noreply.github.com>
Date:   Thu Jan 19 15:46:17 2017 +0100

    Update html.php

    Added code to accept svg files only.
    Also changed names of css classes to suit dokuwiki style.

commit 3435abc52ac1dbd4e0cea291a8b30bef722638a6
Author: ThisNameIsNotAllowed <ThisNameIsNotAllowed@users.noreply.github.com>
Date:   Thu Jan 19 15:41:06 2017 +0100

    Update _admin.css

    Added css for displaying plugin icons.

commit b99c67797eafdb73351f62d2db4c206426b9f828
Author: ThisNameIsNotAllowed <ThisNameIsNotAllowed@users.noreply.github.com>
Date:   Thu Nov 24 14:16:23 2016 +0100

    Update html.php

    Changed the list of admin plugins.

    The icons and plugin names appearance can now be influenced by css.

commit 479c6517ff6fc6010c24b2a285249f3600bc3248
Author: ThisNameIsNotAllowed <ThisNameIsNotAllowed@users.noreply.github.com>
Date:   Thu Nov 24 13:45:08 2016 +0100

    Update html.php

    Cleaned, due to too much duplicated code.

commit e621fd9788c064cc22385cfa4999a9be588bedc2
Author: ThisNameIsNotAllowed <ThisNameIsNotAllowed@users.noreply.github.com>
Date:   Wed Nov 23 16:26:14 2016 +0100

    Update html.php

    Changed class name for images shown before plugin names.

commit 9099dac8483fc1aa5a875755ba3dea6e7eb3f280
Author: ThisNameIsNotAllowed <ThisNameIsNotAllowed@users.noreply.github.com>
Date:   Wed Nov 23 16:24:01 2016 +0100

    Update.html

    Added icon to plugin array

commit faea3ceb7986ecd6d6bad3d8055a388f3810c4b1
Author: ThisNameIsNotAllowed <ThisNameIsNotAllowed@users.noreply.github.com>
Date:   Wed Nov 23 15:56:40 2016 +0100

    Update html.php

    Added support to display plugin icons in admin menu.

commit 539e60be075ab060d7d57beadc74d94606262a2e
Author: ThisNameIsNotAllowed <ThisNameIsNotAllowed@users.noreply.github.com>
Date:   Wed Nov 23 15:51:39 2016 +0100

    Update admin.php

    Add support for icons in admin menu.