Skip to content
Snippets Groups Projects
  1. Oct 30, 2018
    • Andreas Gohr's avatar
      adjust bundled plugins that check for admin permissions · dda9db03
      Andreas Gohr authored
      This adjusts the bundled plugins to do their admin permission checks
      based on their admin component's isAccessibleByCurrentUser() method
      instead of doing their own isAdmin checks.
      dda9db03
    • Andreas Gohr's avatar
      add reerence to the actual plugin to ADMINPLUGIN_ACCESS_CHECK · f429aff5
      Andreas Gohr authored
      Otherwise it's a bit ahrd to decide if access should be granted ;-)
      f429aff5
    • Andreas Gohr's avatar
      add event to check access to admin plugins · 64cdf779
      Andreas Gohr authored
      This adds a new method that capsulates the access check that has to be
      done to decide if an admin plugin's page should be shown to the user.
      The default implementation is the same as before, relying only on the
      forAdminOnly() method and the users' isadmin or ismanager status.
      
      Admin plugins themselves can override the method to do additional
      checks. In this patch, I added that to the usermanager plugin which will
      only return true if the current auth backend can list users.
      
      However the real idea behind this change is that the new method emits a
      new event called ADMINPLUGIN_ACCESS_CHECK which would allow plugins to
      overwrite it. This way it could be possible to give certain user groups
      access to certain admin plugins without giving them admin or manager
      permissions.
      
      Note: this does not change how the "Admin" link is shown, it still
      depends on ismanager or isadmin. A plugin as mentioned above would need
      to influence the display via the MENU_ITEMS_ASSEMBLY event.
      
      Note: this only covers the basic access check. Admin plugins may need
      further adjustments for access to other parts of the plugin (like AJAX
      components). An additional commit will update this for the bundled
      plugins.
      64cdf779
  2. Oct 17, 2018
  3. Oct 14, 2018
  4. Oct 12, 2018
  5. Oct 11, 2018
  6. Sep 27, 2018
  7. Sep 19, 2018
  8. Sep 15, 2018
  9. Sep 12, 2018
  10. Sep 11, 2018
  11. Sep 10, 2018
  12. Sep 08, 2018
  13. Aug 28, 2018
  14. Aug 24, 2018
  15. Aug 16, 2018
  16. Aug 10, 2018
  17. Aug 04, 2018
  18. Aug 01, 2018
  19. Jul 27, 2018
  20. Jul 20, 2018
  21. Jul 02, 2018
  22. Jun 26, 2018
  23. Jun 19, 2018
    • Brend Wanders's avatar
      Change `const` use to `var` for Safari 9 (on iOS) · 018871f4
      Brend Wanders authored
      Safari 9 in iOS does not support the use of `const` in strict mode. Unfortunately, some of us are stuck with Safari 9 due to not being able to upgrade.
      
      I am a big fan of progressive enhancement, but because all javascript code is packed together and sent off to the client, this small incompatibility breaks all javascript for safari 9 browsers. Switching these two keywords makes everything work again.
      
      There are no other uses of `const` in the codebase as far as I can find. This change has little to no impact on anything else, but slighlty extends the range of supported browsers.
  24. Jun 08, 2018
  25. Jun 07, 2018
    • Andreas Gohr's avatar
      removed safemode hack · fe227084
      Andreas Gohr authored
      Safemode has been removed in PHP 5.4.0. We finally no longer need to
      deal with this insanity.
      fe227084
  26. May 22, 2018
  27. May 18, 2018
  28. May 16, 2018
Loading