Skip to content
Snippets Groups Projects
  1. Oct 30, 2018
    • Andreas Gohr's avatar
      add event to check access to admin plugins · 64cdf779
      Andreas Gohr authored
      This adds a new method that capsulates the access check that has to be
      done to decide if an admin plugin's page should be shown to the user.
      The default implementation is the same as before, relying only on the
      forAdminOnly() method and the users' isadmin or ismanager status.
      
      Admin plugins themselves can override the method to do additional
      checks. In this patch, I added that to the usermanager plugin which will
      only return true if the current auth backend can list users.
      
      However the real idea behind this change is that the new method emits a
      new event called ADMINPLUGIN_ACCESS_CHECK which would allow plugins to
      overwrite it. This way it could be possible to give certain user groups
      access to certain admin plugins without giving them admin or manager
      permissions.
      
      Note: this does not change how the "Admin" link is shown, it still
      depends on ismanager or isadmin. A plugin as mentioned above would need
      to influence the display via the MENU_ITEMS_ASSEMBLY event.
      
      Note: this only covers the basic access check. Admin plugins may need
      further adjustments for access to other parts of the plugin (like AJAX
      components). An additional commit will update this for the bundled
      plugins.
      64cdf779
  2. Apr 27, 2018
    • Michael Große's avatar
      feat: improve search as a primary means to create new pages · 42690e4d
      Michael Große authored
      Specifically, this pull request checks if the current query is already a
      valid pageid and then return that as suggested pageid.
      
      Also, tests are added for this method.
      
      Fixes #2355
      
      PS: We may want to somehow better educate/nudge users to use the better
      way of creating pages by creating links on existing pages.
      Unverified
      42690e4d
  3. Apr 20, 2018
  4. Apr 19, 2018
  5. Apr 17, 2018
  6. Apr 15, 2018
    • Anika Henke's avatar
      Fix invalid HTML in search results · 7c15eaa2
      Anika Henke authored
      Recent changes to the search results page added various divs
      to the pre-existing description list, which is invalid.
      This fixes that by a) removing a couple of unnecessary elements
      and b) interpret the 'last modified' line as another 'dd'.
      7c15eaa2
    • Anika Henke's avatar
      Fix links with invalid empty target attributes · 5d021066
      Anika Henke authored
      The advanced search options list links with an invalid empty target
      attribute. This fixes that by skipping empty parameters.
      5d021066
  7. Apr 13, 2018
  8. Mar 29, 2018
  9. Mar 28, 2018
  10. Mar 27, 2018
  11. Mar 26, 2018
  12. Mar 23, 2018
  13. Mar 22, 2018
Loading